-
Notifications
You must be signed in to change notification settings - Fork 26
Updated PDVD geo #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Updated PDVD geo #134
Conversation
In the wirecell configuration (dunereco/DUNEWireCell/protodunevd/), it still assumes the cathode centers are located at X=0. We can update the wirecell configuration if needed. Do we understand the actual position? |
|
@wenqiang-gu thank you for the answer. Can you also confirm the drift lenght in the wirecell config? It was 310 cm up to v2 and then 338.5 from v3 on. |
|
Hi @lpaulucc |
|
Thank you, @YoannKermaidic. I suppose this is the drift wirecell used then and there is no need to make a new configuration once I return the cathode to x=0 😌 |
|
In the mean time, I give few simulations trials this morning with your new files and let you know. |
|
Regarding the overlaps, TPC positions in v5 are exactly the same as the ones seen in this PR (7e23002#diff-b4aef1aca19588eb15eaaf2b350d8137f45bf57421e94fb9bd70cb924f2eb868) but it is causing overlaps. I think the offsets are dislocated on one side but since I am not the one who introduced it, I will not do anything unless I am instructed to. |
In the wirecell, we set the cathode position and extract wire positions from LArSoft. From the current input file, the wire positions are at +/- 341.5 cm, so it should be consistent with 338.5cm drift length. I can rewrite the input file for wire positions once the gdml is updated. |
|
@wenqiang-gu I can solve the TPC overlaps by changing the signs in this bit Should I do that? |
If I understand correctly, here is the layout for 4 quads the coordinate: For quad 0 & quad 1, somehow we should expect same offset in Z and opposite-sign offset in Y? |
|
@lpaulucc, with the latest commit, I get the following error: |
|
@YoannKermaidic perhaps the problem is being caused by the change in the TPC offset. I will undo this change and commit again but it is causing an overlap. |
|
Hi, I confirm that the reverted version works well (i.e. no errors). |
|
Any updates on this discussion? I'd be happy to try to merge when a few reviewers think this PR is ready. |
|
@lpaulucc @YoannKermaidic any updates this week? I can try to merge this Friday morning Chicago time if you can get it approved in time. |
|
Hi @aolivier23, I am checking a possible change needed for the positions of some photon detectors. Let's see if we get this sorted out today. Regarding the overlaps, I am not sure what to do since this was not a change introduced by me and I don't know what impact this can have on the charge sim. |
|
Overlaps can cause random effects and photons disappearing or appearing more than they should. @wenqiang-gu @lhwhitehead and Laura Zambelli any idea how to solve this? |
Hi @lpaulucc , perhaps you could revert the changes in PR #123 ? That PR was introduced to align the TPC offset at the bottom and top for calibration purpose. However, if geometry overlaps are a bigger concern, we could discuss reverting it. By the way , Xin and Nitish presented their Python-based geometry package (GGD) at the last collaboration meeting, and it does not exhibit such overlaps. We could consider transitioning to that package in the future. |
|
One point in addition is that we should put back the CRTs: |
|
Thank you for your answer @wenqiang-gu . I will contact Nitish and ask about the overlap. I will keep you posted. |
|
@lpaulucc @YoannKermaidic any updates on this PR? I'm going to hold off from merging it until you post here (or on Slack if you prefer) that it's ready. Thanks. |
|
Thanks, @aolivier23 . I hope next week to have time to identify the changes that were made in the geometry using GGD to correct the TPC overlaps and make a new (and hopefully final) commit. |
|
Any updates @lpaulucc or others? I'll leave this out of the release this week unless I hear back. I'd be happy to give you a few hours to work on this if you think it's almost ready. |
|
Sorry @aolivier23 , lots of things going on this week, I could not push this forward :-( |
|
@lpaulucc Any updates here? |
|
Unfortunately, no. If anyone else involved in this conversation could help me identify what needs to be changed, it would go faster, since next week there is an FDC EB meeting and in the following one, a LBNC meeting. From Xin |
|
@YoannKermaidic did you by any chance made tests with this geometry? I just looked at the gdd implementation and the code looks the same, active positions look the same, but the ggd gdml has no TPC overlaps... If the simulation is working for both charge and light, maybe it is better to just go ahead. I am having very little time to handle this at the moment :-( |
|
Currently, the GGD file seems to return an error at execution time: So more investigations are required before considering the GGD implementation. |
|
Thank you, Yoann. I asked Wei Shi about it. How were the tests with the perl gased geo with the overlaps? |
|
@lpaulucc I think we can close this PR, isn't it? |
|
I have made one last commit where I remove the v5 gdmls created with the perl script and I update the description of it. I think it might be good to have it clearly somewhere that there is a problem with the perl script so that people don't work on this again unless the problem is fixed. What do you think? |



This new ProtoDUNE-VD geometry includes the following features:
A change in the cathode position has been noticed on v4 (the base geo used for these changes) with respect to v2 (not sure about v3) so that it is no longer at X=0 but at X=-20 cm. This also changed the CRPs' positions in the geometry. @wenqiang-gu would you be able to identify which geometry has been used for the wirecell setup so it can be identified if this change should be reverted or not?
Also, the distance of the beam plug with respect to the cathode should be checked. In the current geometry (v4/v5), these positions are:
BeamSpot_x =-36.58, BeamSpot_y =109.02, BeamSpot_z =-277.41
TPC Origin : (20, 1.13686837721616e-13, 149.65)
Beam Plug position x=202.745856257036 y=238.779338015429 z=-236.979338015429
I am still evaluating some TPC overlaps that apeared when I moved the Arapucas
= Overlap ov00002: volCryostat/volTPC1_0 overlapping volCryostat/volTPC2_0 ovlp=5.5
= Overlap ov00003: volCryostat/volTPC1_0 overlapping volCryostat/volTPC2_0 ovlp=5.5
= Overlap ov00004: volCryostat/volTPC1_0 overlapping volCryostat/volTPC2_0 ovlp=5.5
= Overlap ov00005: volCryostat/volTPC1_0 overlapping volCryostat/volTPC2_0 ovlp=5.5
, which makes no sense, so under investigation.
The overlaps with the beam pipe remain:
= Overlap ov00000: volCryostat extruded by: volCryostat/volBeamPlIIUSCap_0 ovlp=195.539
= Overlap ov00001: volCryostat extruded by: volCryostat/volBeamPlIIMod_0 ovlp=192.02